-
Notifications
You must be signed in to change notification settings - Fork 64
add API spec: IsEnhancedSecurityModeEnabled #5407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: api-IsEnhancedSecurityModeEnabled
Are you sure you want to change the base?
add API spec: IsEnhancedSecurityModeEnabled #5407
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
|  | ||
|
|
||
| Unlike Microsoft Edge, WebView2 does not support the heuristic-based "Balanced" | ||
| level; only Off and Strict are available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a possibility that such a mixed mode could arrive in the future? E.g. SetEnhancedSecurityModeExemptDomains("contoso.com") which lets you say "Turn on ESM for all non-contoso sites"?
Could be
enum CoreWebView2EnhancedSecurityMode
{
Off,
On,
// future: OnForUntrustedDomains
}
runtimeclass CoreWebView2Profile
{
CoreWebView2EnhancedSecurityMode EnhancedSecurityMode { get; set; }
}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, ESM does two things. Suppose that we later think of a third thing. Would we
- Add it to the things you get when you enable ESM
- Make it another tier of ESM that apps have to opt into [IsEnhancedSecurityMode =very true]
- Make it an entirely separate feature (Super-Secure Mode) that apps have to opt into separately from ESM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My expectation based on reading "enabling additional OS protections" is that a third thing could already quietly light up when ESM is on.
If we create this as an enum to make it extensible, should probably be { Off, Strict } (instead of "On") since 3rd+ values (e.g. "Balanced" being supported) would be different flavors of "on".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, in coming APIs we will add support to exempt origins, we can have something like SetESMBypassList: to always not apply enhanced security and SetESMEnforceList: to always apply enhanced security for the origins in the list, irrespective of the ESM level for that profile.
We’re looking to introduce a unified API later for origin-level configurability, since there are several features like tracking prevention, SmartScreen, ESM, and others with origin exemptions capability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes sense to have off and strict enums instead of off and on. We may support balanced mode in future
API to configure Enhanced Security Mode states